Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Support for e/ème/er/ère templates #354

Closed
lasconic opened this issue Nov 24, 2020 · 5 comments · Fixed by #373
Closed

[FR] Support for e/ème/er/ère templates #354

lasconic opened this issue Nov 24, 2020 · 5 comments · Fixed by #373
Assignees

Comments

@lasconic
Copy link
Collaborator

  • Wiktionary page:

Wikicode:

XVI{{ème}}

Output:

XVI<i>Eme</i>

Expected:

XVIe

Model link, if any: https://fr.wiktionary.org/wiki/Mod%C3%A8le:e

@lasconic
Copy link
Collaborator Author

I found this one by logging the templates in the last_template_handler in defaults.py just before the return. I'm sure there is still many templates we don't support that can be discovered like this.

@BoboTiG
Copy link
Owner

BoboTiG commented Nov 24, 2020

Good catch. The whole e template needs more tests, it only handle a few cases.

@lasconic
Copy link
Collaborator Author

@lasconic
Copy link
Collaborator Author

@lasconic
Copy link
Collaborator Author

@lasconic lasconic self-assigned this Nov 25, 2020
lasconic added a commit to lasconic/ebook-reader-dict that referenced this issue Nov 25, 2020
lasconic added a commit to lasconic/ebook-reader-dict that referenced this issue Nov 25, 2020
BoboTiG pushed a commit that referenced this issue Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants