Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1347: Fix data auto-update scripts with double quotes #1349

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

lasconic
Copy link
Collaborator

@lasconic lasconic commented Aug 9, 2022

Fixes #1347

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 9, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.80%.

Quality metrics Before After Change
Complexity 15.44 🙂 15.08 🙂 -0.36 👍
Method Length 163.50 😞 1253.80 ⛔ 1090.30 👎
Working memory 10.58 😞 10.27 😞 -0.31 👍
Quality 40.17% 😞 40.97% 😞 0.80% 👍
Other metrics Before After Change
Lines 152 3018 2866
Changed files Quality Before Quality After Quality Change
scripts/en-labels.py 40.17% 😞 39.82% 😞 -0.35% 👎
wikidict/lang/en/labels.py % 64.01% 🙂 %

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
scripts/en-labels.py process_page 20 😞 261 ⛔ 10 😞 36.84% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@lasconic
Copy link
Collaborator Author

lasconic commented Aug 9, 2022

Tests are not passing. Not sure why.

@BoboTiG
Copy link
Owner

BoboTiG commented Aug 9, 2022

A temporary issue given the "word of the day". It's interesting to see that we need to improve something, but it's not related to your changes.

@BoboTiG
Copy link
Owner

BoboTiG commented Aug 9, 2022

Tests are not passing. Not sure why.

cf #1350

@lasconic lasconic merged commit 0d2b730 into BoboTiG:master Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix data auto-update scripts with double quotes
2 participants