Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] support "diaéthique" template #1456

Merged
merged 1 commit into from
Dec 30, 2022
Merged

[FR] support "diaéthique" template #1456

merged 1 commit into from
Dec 30, 2022

Conversation

BoboTiG
Copy link
Owner

@BoboTiG BoboTiG commented Dec 30, 2022

Fixes #1451

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 30, 2022

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 43.57 ⛔ 43.57 ⛔ 0.00
Method Length 413.00 ⛔ 413.83 ⛔ 0.83 👎
Working memory 14.71 😞 14.71 😞 0.00
Quality 24.25% 24.25% 0.00%
Other metrics Before After Change
Lines 1523 1525 2
Changed files Quality Before Quality After Quality Change
tests/test_fr.py 53.08% 🙂 53.07% 🙂 -0.01% 👎
wikidict/lang/fr/__init__.py 20.94% ⛔ 20.94% ⛔ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
wikidict/lang/fr/__init__.py last_template_handler 63 ⛔ 557 ⛔ 18 ⛔ 7.31% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
tests/test_fr.py test_parse_word 0 ⭐ 483 ⛔ 10 😞 50.32% 🙂 Try splitting into smaller methods. Extract out complex expressions
tests/test_fr.py test_process_templates 0 ⭐ 327 ⛔ 5 ⭐ 64.07% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@BoboTiG BoboTiG merged commit 1c3e751 into master Dec 30, 2022
@BoboTiG BoboTiG deleted the fix-1451 branch December 30, 2022 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] support "diaéthique" template
1 participant