Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Ignore the "cf" template when pointing to the current Wiki page #1514

Merged
merged 1 commit into from Jan 16, 2023

Conversation

BoboTiG
Copy link
Owner

@BoboTiG BoboTiG commented Jan 16, 2023

Fixes #1501

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 16, 2023

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 11.20 🙂 11.20 🙂 0.00
Method Length 80.32 🙂 80.32 🙂 0.00
Working memory 7.35 🙂 7.35 🙂 0.00
Quality 64.25% 🙂 64.25% 🙂 0.00%
Other metrics Before After Change
Lines 1257 1257 0
Changed files Quality Before Quality After Quality Change
wikidict/lang/fr/template_handlers.py 64.25% 🙂 64.25% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
wikidict/lang/fr/template_handlers.py render_compose_de 42 ⛔ 484 ⛔ 13 😞 16.74% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
wikidict/lang/fr/template_handlers.py render_etyl 22 😞 175 😞 11 😞 39.30% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
wikidict/lang/fr/template_handlers.py render_lien_web 20 😞 238 ⛔ 7 🙂 44.63% 😞 Refactor to reduce nesting. Try splitting into smaller methods
wikidict/lang/fr/template_handlers.py render_cit_ref 10 🙂 159 😞 8 🙂 56.55% 🙂 Try splitting into smaller methods
wikidict/lang/fr/template_handlers.py render_equiv_pour 9 🙂 129 😞 9 🙂 58.55% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@BoboTiG BoboTiG merged commit 68523e4 into master Jan 16, 2023
@BoboTiG BoboTiG deleted the fix-1501 branch January 16, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Ignore "cf" when pointing to special pages
1 participant