Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #415: [EN] Support 'named-after' template #418

Merged
merged 1 commit into from Dec 3, 2020

Conversation

lasconic
Copy link
Collaborator

@lasconic lasconic commented Dec 3, 2020

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 3, 2020

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.28%.

Quality metrics Before After Change
Complexity 374.70 ⛔ 395.71 ⛔ 21.01 👎
Method Length 521.80 ⛔ 550.60 ⛔ 28.80 👎
Working memory 36.39 ⛔ 37.41 ⛔ 1.02 👎
Quality 5.13% 4.85% -0.28% 👎
Other metrics Before After Change
Lines 858 890 32
Changed files Quality Before Quality After Quality Change
scripts/lang/en/init.py 5.13% ⛔ 4.85% ⛔ -0.28% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
scripts/lang/en/init.py last_template_handler 441 ⛔ 2412 ⛔ 40 ⛔ 0.18% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
scripts/lang/en/init.py join_names 38 ⛔ 161 😞 16 ⛔ 25.65% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
scripts/lang/en/init.py add_dash 6 ⭐ 54 ⭐ 10 😞 69.91% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@BoboTiG BoboTiG merged commit 1b2938d into BoboTiG:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EN] Support all "form-of" templates
2 participants