Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #683: [FR] Better support for 'siècle' template with I #684

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

lasconic
Copy link
Collaborator

@lasconic lasconic commented Feb 5, 2021

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 5, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.28%.

Quality metrics Before After Change
Complexity 15.58 🙂 16.07 🙂 0.49 👎
Method Length 80.29 🙂 79.24 🙂 -1.05 👍
Working memory 9.88 😞 9.76 🙂 -0.12 👍
Quality 57.43% 🙂 57.71% 🙂 0.28% 👍
Other metrics Before After Change
Lines 739 748 9
Changed files Quality Before Quality After Quality Change
wikidict/lang/fr/template_handlers.py 57.43% 🙂 57.71% 🙂 0.28% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
wikidict/lang/fr/template_handlers.py render_compose_de 55 ⛔ 489 ⛔ 15 😞 11.45% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
wikidict/lang/fr/template_handlers.py render_etyl 17 🙂 161 😞 10 😞 46.13% 😞 Try splitting into smaller methods. Extract out complex expressions
wikidict/lang/fr/template_handlers.py render_mot_valise 13 🙂 126 😞 10 😞 53.27% 🙂 Try splitting into smaller methods. Extract out complex expressions
wikidict/lang/fr/template_handlers.py render_cit_ref 10 🙂 169 😞 8 🙂 55.58% 🙂 Try splitting into smaller methods
wikidict/lang/fr/template_handlers.py render_agglutination 12 🙂 102 🙂 10 😞 57.22% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@BoboTiG BoboTiG merged commit fdac412 into BoboTiG:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Better support for 'siècle' template with I
2 participants