Add communication error in status function. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoboTiG
reviewed
Jan 9, 2019
BoboTiG
reviewed
Jan 9, 2019
|
Thank you very much @d21d3q! |
|
Also add yourself to |
|
Do you want to add yourself to the |
|
I think I can live without it ;) |
|
Thanks! |
|
FI I have some ongoing work and will publish a new version on PyPi very soon. |
|
Then I am looking forwad for it
śr., 9 sty 2019 o 23:40 Mickaël Schoentgen <notifications@github.com>
napisał(a):
… FI I have some ongoing work and will publish a new version on PyPi very
soon.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAd9XPxN6QIAWNWH6bCPzOXu4zbsTB0Xks5vBm8ogaJpZM4Z3-pE>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
having status function that return
Truein case no response from printer might be misleading. In library it is written that it might be usefull if there is no RX connected. This commit makes it backward compatible, but IMO it should rise error by defualt, and be able to suppress... but if user can suppress error (because RX is not connected) then he don't care about printer status, so maybe it would be better to set all fields toFalseby default?