Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix music not stopping fully (playing at low volume forever) when the…
… game is paused. There appears to be a bug introduced in a recent version of Avocado that was causing voice ADSR envelopes to not complete fully. @JaCzekanski this fix might be of interest. The issue was reported by some users of 'PsyDoom' on DoomWorld: https://www.doomworld.com/forum/topic/111024-psydoom-formerly-stationdoom-reverse-engineered-source-port-of-psx-doom-for-pc-early-progress/?page=4
- Loading branch information
d8203f6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BodbDearg Thanks for the heads up.
I'll try to check your bugfix as soon as I have a way to compare it against the real hardware - currently I'm waiting for parts to mod my PS1 for digital audio capture.
Then I'll be able to improve my implementation and find such bugs.
d8203f6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're welcome! That sounds like a nice addition to your arsenal :) Looking forward to seeing the advancements that come from being able to directly compare against the real hardware.
d8203f6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clearly a regression - didn't test my changes before removing float-based computations.
Fixed in latest commit using slightly simpler method.
d8203f6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for the update!