Log sieve #210
Merged
Log sieve #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federico-bongiorno
force-pushed
the
log_sieve
branch
from
5597676
to
f3e6d08
Compare
Bodigrim
reviewed
Aug 12, 2020
Bodigrim
reviewed
Aug 14, 2020
Bodigrim
reviewed
Aug 18, 2020
federico-bongiorno
force-pushed
the
log_sieve
branch
from
c05804c
to
4d9c43a
Compare
Bodigrim
reviewed
Aug 21, 2020
| -- This routine takes the @sievedInterval@ as input, it first filters for smooth numbers | ||
| -- using the given threshold and then checks which of the filtered numbers are smooth | ||
| -- by computing their factorisation by trial division. | ||
| findLogSmoothNumbers :: [Prime Int] -> Int -> Int -> [(Prime Integer, Word)] -> Integer -> V.Vector (Integer, Int) -> V.Vector (Integer, I.IntMap Int) |
There was a problem hiding this comment.
I suggest changing this function to take V.Vector Integer and U.Vector Int separately, and return Map Integer (I.IntMap Int) immediately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sieving after taking logarithms