20 consider including and consuming the qc documentation from dv.templates #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorinvoicu
reviewed
Jun 5, 2024
sorinvoicu
previously approved these changes
Jun 5, 2024
…ocumentation-from-dvtemplates
sorinvoicu
previously approved these changes
Jun 5, 2024
By default bash is run with -e in GH Actions.
…ocumentation-from-dvtemplates
otherwise it would upload an empty artifact and the ci will fail in the pkgdown step
sorinvoicu
reviewed
Jun 6, 2024
sorinvoicu
reviewed
Jun 6, 2024
sorinvoicu
approved these changes
Jun 7, 2024
|
closes #20 |
zsigmas
deleted the
20-consider-including-and-consuming-the-qc-documentation-from-dvtemplates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force that when during packages are build process dv.templates qc documentation is used to avoid code drifting
Does not cover automatic vignette inclusion, managing that seems overdoing at this moment.