Development #71
Merged
Development #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merging updates
* Use of proc contents instead of dictionary tables * Use of datastep to create macvars negates the need for noprint option on SQL (the remaining proc SQL does not send to print output). Also, no * longer limited to 999 columns. replaced ```format _all_;``` with ```format _numeric_ best32.;``` to gain maximum precision for numerics. Note that character formats are no longer stripped. Could not think of a use case for this.. But to re-enable stripping of character formats, just add another line (```format _character_;```)
adding %else for efficiency removing redundant code
need to retain variable order to preserve downstream logic in customer app
fix to avoid conflict with reserved USER variable in proc sql approach. Fixes #27.
reverting to SQL view (datastep view caused 'could not parse json' issue on client side)
|
dist has been rebuilt, all conflicts resolved, tests are passing - should be good to go (has updated README also) |
…sm in the adapter
…ng README to point out the 9.4 only support (now we use proc json).
…de strict=true in tsconfig.json'
this update is require for clarity-seed-app to works properly with mo…
updating to use CRLF as newline delimeter in CSV upload. Also, updat…
feat: enable SAS error handling, closes #79
fix: #82 - Prevent double quotes update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release for Version 1 of the adapter. This uses the file upload mechanism, which is orders of magnitude faster than using macro variables for sending data to SAS. It also now uses proc json to return data to SAS, alternatively it will use the old method if the SAS installation is lower than 9.4.
Note the new syntax for obtaining tables:
%bafgetdatasets()- this will convert ALL input files to SAS datasets (no longer need one call per dataset)And for sending tables back to the frontend:
On the javascript side there is a new function for creating data:
var myData=new h54s.SasData([{col1: "some_string, col2: 1}],'forSAS')