Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecrumbs views don't finish loading #31

Closed
adityavm opened this issue Feb 23, 2019 · 9 comments
Closed

Codecrumbs views don't finish loading #31

adityavm opened this issue Feb 23, 2019 · 9 comments

Comments

@adityavm
Copy link

My Codecrumbs browser is in a perpetual loading state. I've added some logging on my end and it seems to be parsing the //cc comments properly, so I can't figure out why there is no visualisation.

Browser
codecrumbs

Debug
parsed

@Bogdan-Lyashenko
Copy link
Owner

Bogdan-Lyashenko commented Feb 24, 2019

Hi, can you check browser console in devtools, probably there is an uncaught error. Also, can you please show your command how do you run it? (codedrumbs params). Also, which version do you use, please make sure it’s latest. Thanks. :)

@adityavm
Copy link
Author

adityavm commented Feb 24, 2019

@Bogdan-Lyashenko no errors in the console:
console

and here's the command to run it. i've tried various entry points, none of them work:

command

(i've also tried it with a global codecrumbs installation, still doesn't work)

and the version is 1.1.1 (it's in the bottom left of the first screenshot 🙂)

to add some more debug information (probably relevant), the React containers seem to be halting at this

if (!namespace) {
return {};
}

shown by the lack of children in the ExplorerBarContainer and SideBarContainer:

no children

@Bogdan-Lyashenko
Copy link
Owner

Bogdan-Lyashenko commented Feb 24, 2019

@adityavm for what project are you running codecrumbs?
Let's do this example to see how everything works:

  1. clone/download to your computer this project https://github.com/lucasbento/react-redux-todo (just as simple example)
  2. install codecrumbs - yarn global add codecrumbs
  3. go to the folder react-redux-todo (where you copied project from step 1)
  4. run codecrumbs -d src -e src/index.js
  5. go to the browser url http://localhost:2018 to see if it works

let me know if this works and then we can continue from there. Most likely it's something with paths how do you run it, but I definitely should add more logs to track where it gets stuck 😸
Thanks for your help 🙂

@adityavm
Copy link
Author

@Bogdan-Lyashenko it's a personal project. react-redux-todo works fine.
react-redux-todo

i also thought that it might be because of paths, however logging the paths from the different parser scripts seems to output the correct full path (second screenshot in this thread). i use absolute module paths, like:

import Something from "component/Something";

could that be an issue?

@Bogdan-Lyashenko
Copy link
Owner

import Something from "component/Something";
could that be an issue?
No, it should be fine, it might not be resolved by dependencies tree builder (Dependencies tab on UI) but it will not affect the entire picture.

So you ran codecrumbs for your project in the exact same way as you just did for react-redux-todo and it still doesn't work. That's super interesting... 👀 Alright, I will go through setup and add more error handling and logs. But basically, I assume it doesn't init here
https://github.com/Bogdan-Lyashenko/codecrumbs/blob/master/src/server/project-source/index.js#L75.

@adityavm
Copy link
Author

@Bogdan-Lyashenko feel free to email me / ping me here if you need me to test out pre-release versions. codecrumbs looks super useful, so happy to help however 👍

@Bogdan-Lyashenko
Copy link
Owner

@adityavm hi there 🙂 I just pushed version with extra logs. When you have a free minute, can you please update to v1.1.2 (or higher) and run it again? So I covered with logs file structure parsing and also added log to browser to see what you are receiving in the end. Let's see 😸

@Bogdan-Lyashenko
Copy link
Owner

@adityavm try v1.1.4, should be golden now 😸

@adityavm
Copy link
Author

@Bogdan-Lyashenko confirmed. works well. thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants