fixed IndexOfBytes bug #125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revan1985
pushed a commit
to Revan1985/RtspClientSharp
that referenced
this pull request
Nov 28, 2023
…vKirill#125 from BogdanovKirill/RtspClientSharp repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArrayUtils IndexOfBytes needs to move its startIndex back if a partially successful match ends up mismatching. Otherwise a match that starts within this attempted match will be missed.
I noticed this happen in H264Slicer.Slice. It missed a second nal unit start marker (0001) because the bytes contained 00001 which matched the start marker up to 000 and correctly gave up the match when the next 0 didn't match the needed 1. But then it continued without moving the start index back, so missed the 0001 match and returned -1.
My video still played regardless. The nal unit type was type 8 and I'm not sure what that impacts.
I added a test case to cover this.