Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: drop Python 3.6 #478

Merged
merged 3 commits into from Jun 12, 2022
Merged

build: drop Python 3.6 #478

merged 3 commits into from Jun 12, 2022

Conversation

staticdev
Copy link
Contributor

Closes #477

@staticdev
Copy link
Contributor Author

@Bogdanp could you review my PR please?

@Bogdanp
Copy link
Owner

Bogdanp commented Mar 15, 2022

Thanks. This looks fine, but I'm not in a hurry to remove 3.6 yet.

@staticdev
Copy link
Contributor Author

staticdev commented Mar 15, 2022

Thanks. This looks fine, but I'm not in a hurry to remove 3.6 yet.

@Bogdanp My idea is to contribute to dramatiq type checking capabilities, but python 3.6 offers very poor support and many problems with type checking. This is the main reason of this PR. From 3.7, things are much smoother with from __future__ import annotations. Please consider that, since most modern libraries such as dramatiq have fully enabled annotations for the applications using it.

Also as I mentioned in #477, 3.6 EOL was on 23 Dec 2021, we are almost done with python 3.11 ;)

@Bogdanp
Copy link
Owner

Bogdanp commented Mar 15, 2022

Feel free to work on that with dropping 3.6 in mind, but I think we'll wait at least another 6 months before actually dropping 3.6, like we did 3.5 (around 1 year after it was EOL'd). Users may move more slowly than Python core does and I value stability more than I value new features.

@Bogdanp Bogdanp merged commit 1482315 into Bogdanp:master Jun 12, 2022
@staticdev staticdev deleted the build/drop-36 branch June 12, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Python 3.6
2 participants