Add support for timedelta as actor delay#569
Merged
Merged
Conversation
h3nnn4n
marked this pull request as ready for review
August 20, 2023 15:26
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements #522 as suggested by @dragonpaw
Support for using
timedeltafor the actor delay was added at the public interface. Alternatively it could have been implemented by switching to timedelta internally and converting to int / float when interfacing with external libraries. This would improve type safety in dramatiq, but it is a more intrusive change.Based on feedback from this PR I can open a followup to support
timedeltafor timeout args as well.