Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recompute keys in atomic incr with sliding window #69

Merged
merged 3 commits into from Apr 17, 2018
Merged

Recompute keys in atomic incr with sliding window #69

merged 3 commits into from Apr 17, 2018

Commits on Apr 16, 2018

  1. fix: recompute incr_and_sum key list with callable 

    Change the `WindowRateLimiter` to pass a callable to `incr_and_sum` so
that during atomic increments the time windows can be recomputed in the
event of a lock.

This breaks the API because we change `incr_and_sum`'s `keys` arg to
a callable. We keep backwards compatibility by checking if `keys` is
callable and calling it on each use.
    @gdvalle
    gdvalle committed Apr 16, 2018
    Copy the full SHA
    e411ca5 View commit details
    Browse the repository at this point in the history

  2. chore: add gdvalle to contributors

    @gdvalle
    gdvalle committed Apr 16, 2018
    Copy the full SHA
    bbc3299 View commit details
    Browse the repository at this point in the history

  3. fix: update docs for incr_and_sum behavior

    @gdvalle
    gdvalle committed Apr 16, 2018
    Copy the full SHA
    8528e4c View commit details
    Browse the repository at this point in the history