Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recovery functions to EthereumSignedTransaction #173

Merged
merged 6 commits into from
May 2, 2024

Conversation

Florian-S-A-W
Copy link
Member

Add from, publicKey and unsignedMessage recovery functions to EthereumSignedTransaction

koraykoska
koraykoska previously approved these changes Apr 30, 2024
Copy link
Member Author

@Florian-S-A-W Florian-S-A-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 91.46341% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 74.67%. Comparing base (9c362d2) to head (1d23043).

Files Patch % Lines
Sources/Core/Transaction/EthereumTransaction.swift 91.46% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
- Coverage   75.07%   74.67%   -0.40%     
==========================================
  Files          68       68              
  Lines        5303     3885    -1418     
==========================================
- Hits         3981     2901    -1080     
+ Misses       1322      984     -338     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Florian-S-A-W Florian-S-A-W merged commit b85187d into master May 2, 2024
3 of 4 checks passed
@koraykoska koraykoska deleted the feat/EthereumSignedTx-from branch May 2, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants