Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Conflict with PolyLang, Header/Footer Layout Controls do not function #401

Closed
jessecowens opened this issue Jun 9, 2021 · 4 comments
Labels
bug General bug issues
Milestone

Comments

@jessecowens
Copy link
Member

jessecowens commented Jun 9, 2021

Describe the bug
If the popular PolyLang translation plugin is active and configured with 2 or more languages, the header and footer layout controls ( +Widget, +Branding, +Menu, Trash Can, etc) do not function, and a JavaScript error is thrown.

To Reproduce
Steps to reproduce the behavior:

  1. Install WordPress with Crio and PolyLang

  2. Add at least 2 languages in the PolyLang Setup Wizard
    image

  3. Navigate to the Customize > Design > Footer > Layout menu

  4. Note that you cannot add or delete rows and elements

Expected behavior
The header and footer layout controls should function.

Screenshots
footer-widgets

Additional context
This issue was reported in the BoldGrid Support Forums

jquery.js?ver=3.5.1:4055 Uncaught TypeError: Cannot read property 'active' of undefined
    at child.toggleUsedLocations (base-controls.min.js?ver=2.8.0:1)
    at Function.<anonymous> (base-controls.min.js?ver=2.8.0:1)
    at fire (jquery.js?ver=3.5.1:3496)
    at Object.fireWith [as resolveWith] (jquery.js?ver=3.5.1:3626)
    at customize-base.js?ver=5.7.2:537
    at fire (jquery.js?ver=3.5.1:3496)
    at Object.add [as done] (jquery.js?ver=3.5.1:3555)
    at Function.when (customize-base.js?ver=5.7.2:522)
    at Function.instance (customize-base.js?ver=5.7.2:368)
    at magic (customize-base.js?ver=5.7.2:98)
toggleUsedLocations @ base-controls.min.js?ver=2.8.0:1
(anonymous) @ base-controls.min.js?ver=2.8.0:1
fire @ jquery.js?ver=3.5.1:3496
fireWith @ jquery.js?ver=3.5.1:3626
(anonymous) @ customize-base.js?ver=5.7.2:537
fire @ jquery.js?ver=3.5.1:3496
add @ jquery.js?ver=3.5.1:3555
when @ customize-base.js?ver=5.7.2:522
instance @ customize-base.js?ver=5.7.2:368
magic @ customize-base.js?ver=5.7.2:98
(anonymous) @ base-controls.min.js?ver=2.8.0:1
(anonymous) @ base-controls.min.js?ver=2.8.0:1
fire @ jquery.js?ver=3.5.1:3496
fireWith @ jquery.js?ver=3.5.1:3626
trigger @ customize-base.js?ver=5.7.2:160
(anonymous) @ customize-controls.js?ver=5.7.2:9291
mightThrow @ jquery.js?ver=3.5.1:3762
process @ jquery.js?ver=3.5.1:3830
setTimeout (async)
jQuery.readyException @ jquery.js?ver=3.5.1:4054
(anonymous) @ jquery.js?ver=3.5.1:4074
mightThrow @ jquery.js?ver=3.5.1:3762
process @ jquery.js?ver=3.5.1:3830
setTimeout (async)
(anonymous) @ jquery.js?ver=3.5.1:3868
fire @ jquery.js?ver=3.5.1:3496
fireWith @ jquery.js?ver=3.5.1:3626
fire @ jquery.js?ver=3.5.1:3634
fire @ jquery.js?ver=3.5.1:3496
fireWith @ jquery.js?ver=3.5.1:3626
process @ jquery.js?ver=3.5.1:3850
setTimeout (async)
(anonymous) @ jquery.js?ver=3.5.1:3868
fire @ jquery.js?ver=3.5.1:3496
fireWith @ jquery.js?ver=3.5.1:3626
fire @ jquery.js?ver=3.5.1:3634
fire @ jquery.js?ver=3.5.1:3496
fireWith @ jquery.js?ver=3.5.1:3626
ready @ jquery.js?ver=3.5.1:4106
completed @ jquery.js?ver=3.5.1:4116
jquery.js?ver=3.5.1:4055 Uncaught TypeError: Cannot read property 'expanded' of undefined
    at u (base-controls.min.js?ver=2.8.0:1)
    at e.value (base-controls.min.js?ver=2.8.0:1)
    at e.value (base-controls.min.js?ver=2.8.0:1)
    at HTMLDocument.<anonymous> (base-controls.min.js?ver=2.8.0:1)
    at mightThrow (jquery.js?ver=3.5.1:3762)
    at process (jquery.js?ver=3.5.1:3830)
@jamesros161 jamesros161 added the bug General bug issues label Jul 6, 2022
@jamesros161 jamesros161 added this to the 2.16.3 milestone Aug 24, 2022
jamesros161 added a commit that referenced this issue Aug 29, 2022
jamesros161 added a commit that referenced this issue Aug 30, 2022
@jamesros161
Copy link
Contributor

The issue here is likely related, and also resolved by PR#729 https://github.com/BoldGrid/crio-premium/issues/93

@nicolepaschen
Copy link
Member

If I select a hover style that does not use a secondary color the option should not show but it does:
secondary-color-should-not-show-if-not-used

Stable:
stable

@nicolepaschen
Copy link
Member

Advanced menu properties do not work as expected:
menu-advanced-missing

@jamesros161
Copy link
Contributor

Advanced menu properties do not work as expected: menu-advanced-missing menu-advanced-missing

This appears to actually be a bug with PolyLang. Replicated this with PolyLang + TwentyTwenty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug General bug issues
Projects
None yet
Development

No branches or pull requests

3 participants