Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatically update palette selectors #758

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

jamesros161
Copy link
Contributor

@jamesros161 jamesros161 commented Oct 26, 2022

Resolves BoldGrid/crio#108

Testing Instructions

  1. Install Test Zip
    crio.zip
  2. Open Customizer.
  3. Change Color Palette.
  4. Check palette selector controls, and ensure that they all updated to show the new color palette, and that the corresponding elements change color appropriately.

List of known color palette controls

"bgtfw_blog_header_background_color",
"bgtfw_blog_post_background_color",
"bgtfw_header_color",
"bgtfw_menu_background_main",
"bgtfw_menu_items_link_color_main",
"bgtfw_menu_items_active_link_color_main",
"bgtfw_menu_items_active_link_background_main",
"bgtfw_global_title_background_color",
"bgtfw_primary_button_background",
"bgtfw_secondary_button_background",
"bgtfw_menu_background_home-main-menu_853",
"bgtfw_menu_items_link_color_home-main-menu_853",
"bgtfw_menu_items_active_link_color_home-main-menu_853",
"bgtfw_menu_items_active_link_background_home-main-menu_853",
"boldgrid_background_color",
"bgtfw_menu_submenu_background_main",
"bgtfw_menu_items_sub_link_color_main",
"bgtfw_menu_items_sub_active_link_color_main",
"bgtfw_headings_color",
"bgtfw_primary_button_border_color",
"bgtfw_secondary_button_border_color",
"bgtfw_background_overlay_color",
"bgtfw_blog_post_header_title_color",
"bgtfw_blog_post_header_date_link_color",
"bgtfw_blog_post_header_byline_link_color",
"bgtfw_blog_post_readmore_link_color",
"bgtfw_blog_post_tags_link_color",
"bgtfw_blog_post_cats_link_color",
"bgtfw_blog_post_comments_link_color",
"bgtfw_posts_tags_link_color",
"bgtfw_posts_cats_link_color",
"bgtfw_posts_navigation_link_color",
"bgtfw_footer_color",
"bgtfw_menu_border_color_main",
"bgtfw_menu_items_border_color_main",
"bgtfw_menu_items_hover_color_main",
"bgtfw_menu_items_hover_link_color_main",
"bgtfw_menu_items_hover_background_main",
"bgtfw_menu_items_active_link_border_color_main",
"bgtfw_global_title_color",
"bgtfw_site_title_color",
"bgtfw_tagline_color",
"bgtfw_body_link_color",
"bgtfw_posts_date_link_color",
"bgtfw_posts_byline_link_color",
"bgtfw_menu_hamburger_main_color",
"bgtfw_blog_border_color",
"bgtfw_footer_border_color",
"bgtfw_header_border_color",
"bgtfw_header_overlay_color",
"bgtfw_footer_links"

@jamesros161 jamesros161 linked an issue Oct 28, 2022 that may be closed by this pull request
@jamesros161 jamesros161 linked an issue Oct 28, 2022 that may be closed by this pull request
@nicolepaschen
Copy link
Member

nicolepaschen commented Oct 28, 2022

Site Content > Page Titles > Background Color uses old palette in live preview but the palette shown in the Customizer is the new one. Front end also shows the old palette color.
page-title

@nicolepaschen
Copy link
Member

Site Content > Links > Link Color
Live preview shows old palette but the front end is correct.

@nicolepaschen
Copy link
Member

nicolepaschen commented Oct 28, 2022

Design > Blog > Blog Page > Background Colors

I have no clue where it's getting the colors from for the Post Header. I have the featured image hidden. Front end is correct tho just a live preview bug.
unknown-palette

@nicolepaschen
Copy link
Member

Design > Blog > Blog Page > Post Meta > Date Link / Author Link Colors > Custom
Live preview bug front end is correct

image

@nicolepaschen
Copy link
Member

Design > Blog > Blog Page > Read More Links > Link Custom color
Live preview bug front end is correct
image

@nicolepaschen
Copy link
Member

I'm going to guess that Blog > Blog Page > Links > Tag Links, Category Links, and Comment links will have the same live preview issue.

@nicolepaschen
Copy link
Member

nicolepaschen commented Oct 28, 2022

Old palette still shows on the sidebar however the live preview uses the new palette
Footer Column 1 2 and 3 also show old palette
image

@nicolepaschen
Copy link
Member

Design > Blog > Posts > Post Meta > Date / Author Link Color > Custom
Live preview shows old palette front end is correct
image

@nicolepaschen
Copy link
Member

nicolepaschen commented Oct 28, 2022

Design > Blog > Posts > Links > Post Navigation Links > Custom
Live preview shows old palette front end is correct.

Design > Blog > Posts > Links >
Going to guess the Custom option for Tag Links and Category Links are incorrect as well.

@nicolepaschen
Copy link
Member

nicolepaschen commented Oct 28, 2022

Header > Background > Header Overlay
live preview AND front end show old palette with a YouTube video background or image background

Base automatically changed from branch-2.17.2 to master November 2, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bgtfw-palette-selector controls are not updating their values when color palette is changed
3 participants