Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally load steller.js #569

Merged
merged 2 commits into from Feb 8, 2024
Merged

Conditionally load steller.js #569

merged 2 commits into from Feb 8, 2024

Conversation

jamesros161
Copy link
Collaborator

ISSUE: Resolves #517

PROJECT: PPB Issues

Conditionally load steller.js

Test Files

post-and-page-builder-premium-1.1.4-issue-517.zip

NOTES TO TESTER

Please leave comments regarding issues found in testing directly on the issue linked above, not the Pull Request. This helps ease the process of reviewing the testing of multiple PRs in a given project from the project view.

Please remember to move this item from 'Needs Review' to either 'In Progress' or 'Awaiting Release' depending on the results of your testing

Testing Instructions

  1. Install the test zip files linked above.
  2. View a page that does NOT utilize the parallax background feature.
  3. Use the Chrome Dev Tools to view the list of JS files loaded ( this can be done under the 'Network' tab of the dev tools )
  4. Ensure that the file jquery.stellar.js is not loaded.
  5. Edit the page to include a parallax background somewhere on the page.
  6. Reload the page and ensure that the jquery.stellar.js file IS loaded and that the parallax effect works as expected.

@jamesros161 jamesros161 merged commit 293c187 into master Feb 8, 2024
3 checks passed
@jamesros161 jamesros161 deleted the issue-517 branch February 8, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] stellar.js library loads even when its not used
2 participants