Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax python restrictions to allow Python >= 3.8 -> 3.9 #30

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

oschwengers
Copy link
Contributor

Hi Savojardo,
currently, DeepSig pinpoints dependencies for Python, keras and tensorflow to 3.8, 2.4.3 and 2.2.0, respectively. However, this will forestall many useful updates and might hinder the creation of larger environments using DeepSig with other tools.

To integrate DeepSig into Bakta, I once again took a look and successfully managed to increase Python, keras and tensorflow dependencies to 3.9, 2.6.0 and 2.6.2, respectively. This also worked with Python 3.8:

To streamline these verison bumps I also added two unit tests that are automatically triggered on each commit and executed by the GitHub CI system:

  • Python packaging: 7198f0b
  • Conda based execution of DeepSig on a very tiny test data set (2 bacterial aa sequences): 0ba2842

I think this might be a worthy step forwards in terms of long term software stability and usability. Could you please take a look at this, test it yourself and consider this PR?

@oschwengers
Copy link
Contributor Author

You can take a look at the the last and successful unit tests at:

Unfortunately, I had to disable these tests from MacOS as the CI was not able to execute biocrf-static. I guess this is not related to the CI and maybe a distinct issue with DeepSig and MacOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant