Relax python restrictions to allow Python >= 3.8 -> 3.9 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bump python keras and tensorflow dependencies to keras>=2.6.0,<2.7 tensorflow>= 2.6.2, <2.7
bump keras and tensorflow conda dependencies to: keras>=2.6.0, <2.7 tensorflow>=2.6.2, <2.7
|
You can take a look at the the last and successful unit tests at:
Unfortunately, I had to disable these tests from MacOS as the CI was not able to execute |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Savojardo,
currently, DeepSig pinpoints dependencies for Python, keras and tensorflow to 3.8, 2.4.3 and 2.2.0, respectively. However, this will forestall many useful updates and might hinder the creation of larger environments using DeepSig with other tools.
To integrate DeepSig into Bakta, I once again took a look and successfully managed to increase Python, keras and tensorflow dependencies to 3.9, 2.6.0 and 2.6.2, respectively. This also worked with Python 3.8:
To streamline these verison bumps I also added two unit tests that are automatically triggered on each commit and executed by the GitHub CI system:
I think this might be a worthy step forwards in terms of long term software stability and usability. Could you please take a look at this, test it yourself and consider this PR?