Fixed handling of BFIncludeStatusBarInSizeAlways #129
Conversation
| XCTAssert(sizeThatFitsIncludingStatusBar.height > sizeThatFitsNotIncludingStatusBar.height); | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
Nit: Remove unneeded whitespace.
There was a problem hiding this comment.
The usage of blank lines is similar in the other tests of that file. Wouldn't want to break the coding style here.
There was a problem hiding this comment.
Somewhat. There are 2 blank lines here, compared to a single line between every other test here.
There was a problem hiding this comment.
Thanks. Got it now – after believing first you meant the blank lines within the tests, not the 2 after it.
There was a problem hiding this comment.
Do you consider it best to restore the blank lines within the tests?
There was a problem hiding this comment.
It's ok if you remove them. Looks good enough 😁
|
LGTM, passing to @mingflifb for review. |
widescape
force-pushed
the
fix-includeStatusBarInSize
branch
3 times, most recently
from
f32670b
to
45bc71f
Compare
widescape
force-pushed
the
fix-includeStatusBarInSize
branch
from
45bc71f
to
eda11b9
Compare
Fixed handling of BFIncludeStatusBarInSizeAlways
|
@widescape updated the pull request. |
When includeStatusBarInSize was set to BFIncludeStatusBarInSizeAlways, it didn't actually include the status bar in its size.