Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Xcode analyze warning #304

Merged
merged 1 commit into from Aug 27, 2017
Merged

Fix Xcode analyze warning #304

merged 1 commit into from Aug 27, 2017

Conversation

baoshan
Copy link
Contributor

@baoshan baoshan commented Aug 27, 2017

Below analyze hints can be found:

BFTask.m:89:12: nil passed to a callee that requires a non-null 1st parameter.

...
return [[self alloc] initWithResult:result];

This PR fix the analyze warning. Please check if the diff makes any sense.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@nlutsenko
Copy link
Member

Hey @baoshan, thank you for fixing it and welcome to the list of contributors.
This is good to go and should have been that way in the first place, since the public API declares the result in the class contructor as billable anyway.

@nlutsenko nlutsenko merged commit 3b11323 into BoltsFramework:master Aug 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants