Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better -(NSString*)description for BFTask #78

Merged
1 commit merged into from Jan 26, 2015
Merged

Better -(NSString*)description for BFTask #78

1 commit merged into from Jan 26, 2015

Conversation

josephearl
Copy link

See #67 for the original PR.

Updated with @nlutsenko-fb comments and squashed. Also added a small test.

@josephearl
Copy link
Author

Build needs re-running, tests passed but then

/Users/travis/build.sh: line 41:  1181 Segmentation fault: 11  xcodebuild -project Bolts.xcodeproj -sdk macosx -scheme MacBolts

@ghost
Copy link

ghost commented Jan 26, 2015

Re-enqueued build.
Xcode

@josephearl
Copy link
Author

I just pushed a small changed that fixed the formatting (from -(NSString*)description to - (NSString *)description)

@ghost
Copy link

ghost commented Jan 26, 2015

Looks great! Merging now.

ghost pushed a commit that referenced this pull request Jan 26, 2015
@ghost ghost merged commit 50b3310 into BoltsFramework:master Jan 26, 2015
@facebook-github-bot
Copy link
Contributor

@josephearl updated the pull request.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants