Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversion for Swift 5 #85

Closed
wants to merge 2 commits into from
Closed

Conversion for Swift 5 #85

wants to merge 2 commits into from

Conversation

bpisano-luna
Copy link

Ready for Swift 5 :

  • Removed empty parameter in enum TaskState
  • Updated project setting for base localization
  • Removed warning in print by casting Void value to String

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@JoelMarcey JoelMarcey requested a review from nlutsenko May 20, 2019 19:35
@JoelMarcey
Copy link

@nlutsenko - I got an email from @bpisano-luna about this PR:

I created a pull request for supporting Swift 5. But your continuous integration won’t compile with Swift 5 witch seems logical. But You seems to ignore pull request that does not pass your continuous tests. So it seems that your framework will never be usable for the newer Swift versions. Can you please review the pull request or guide me on something to do.

HeEAaD
HeEAaD reviewed May 23, 2019
View reviewed changes
BoltsSwift.xcodeproj/project.pbxproj
};
name = Debug;
};
87FEF3811A9085FA00C60678 /* Release */ = {
isa = XCBuildConfiguration;
baseConfigurationReference = 812DB52B1D3597BF00552C9F /* BoltsSwiftTests-iOS.xcconfig */;
buildSettings = {
SWIFT_VERSION = 5.0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bpisano-luna this project uses xcconfigs to define the SWIFT_VERSION.
Please revert all "SWIFT_VERSION"-changes in this file and change the SWIFT_VERSION in all "Configurations/*xcconfig" files.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your reply. I missed this part. I've changed all the version to Swift 5.0 in the configs and also incremented the version number to 1.5.0

@nlutsenko nlutsenko mentioned this pull request Sep 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeEAaD HeEAaD HeEAaD left review comments

@nlutsenko nlutsenko Awaiting requested review from nlutsenko

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bpisano-luna @facebook-github-bot @JoelMarcey @HeEAaD