chore: address minor review feedback

BoltzExchange · Apr 18, 2024 · 874abc9 · 874abc9
1 parent 1459b1e
commit 874abc9
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/lib/Config.ts b/lib/Config.ts
@@ -49,7 +49,7 @@ type LiquidChainConfig = ChainConfig & {
 
 type PreferredWallet = 'lnd' | 'core' | undefined;
 
-type BaseCurrencyConfig = {
+type BaseCurrencyConfig<T = ChainConfig> = {
   symbol: string;
   network: Network;
 
@@ -62,7 +62,7 @@ type BaseCurrencyConfig = {
 
   maxZeroConfAmount: number;
 
-  chain: ChainConfig;
+  chain: T;
 };
 
 type RoutingOffsetException = {
@@ -185,9 +185,7 @@ type ConfigType = {
   pairs: PairConfig[];
   currencies: CurrencyConfig[];
 
-  liquid?: Omit<BaseCurrencyConfig, 'chain'> & {
-    chain: LiquidChainConfig;
-  };
+  liquid?: BaseCurrencyConfig<LiquidChainConfig>;
 
   rsk?: RskConfig;
   ethereum: EthereumConfig;

diff --git a/lib/chain/ElementsWrapper.ts b/lib/chain/ElementsWrapper.ts
@@ -40,8 +40,8 @@ class ElementsWrapper
       this.emit('block', blockHeight),
     );
 
-    // Only emit confirmed transactions from the public client when a lowball
-    // client is configured
+    // If we have a lowball client, bubble up only confirmed transactions
+    // of the public client
     const hasLowball = this.lowballClient() !== undefined;
 
     this.publicClient().on('transaction', ({ transaction, confirmed }) => {

diff --git a/test/integration/chain/ElementsWrapper.spec.ts b/test/integration/chain/ElementsWrapper.spec.ts
@@ -25,7 +25,7 @@ describe('ElementsWrapper', () => {
     wrapper.disconnect();
   });
 
-  test('should have currenType', () => {
+  test('should have currencyType', () => {
     expect(wrapper.currencyType).toEqual(CurrencyType.Liquid);
   });