feat: initial chainswaps #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackstar12
force-pushed
the
chain-swaps
branch
6 times, most recently
from
770e07b
to
5bbd21d
Compare
michael1011
reviewed
Apr 4, 2024
boltz/swaptree.go
Outdated
Comment on lines
237
to
240
| fmt.Println("expected") | ||
| fmt.Println(txscript.DisasmString(expectedScript)) | ||
| fmt.Println("actual") | ||
| fmt.Println(txscript.DisasmString(actual)) |
jackstar12
force-pushed
the
chain-swaps
branch
3 times, most recently
from
0ed11a8
to
9eaa51e
Compare
michael1011
reviewed
Apr 12, 2024
Co-authored-by: michael1011 <me@michael1011.at>
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
kilrau
requested changes
Apr 24, 2024
kilrau
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
db migration works now (implemented in 75dfa6f in a different branch). Let's merge this one if good with you @michael1011
michael1011
approved these changes
Apr 26, 2024
* feat: chain swap cli * fix: chain swap help description * fix: help output missing , statement * fix: chain swap help description from/to * fix: createswap,createreverseswap,createchainswap help description * fix: autoswapper -> autoswap in help outputs, comments * fix: typo * refactor: dont implicitly select wallets * fix: check for state in timeout condition when querying refundable swaps * fix: only set fees of valid outputs after transaction was created * feat: implicitly set external pay in cli when not specifying from wallet * chore: cleanup * fix: check if value is less than fee when constructing transaction * feat: return output specific errors when creating transactions * fix: refund help description * fix: --from-external, --to-address help output * refactor: dont default to mainchain when creating swap * refactor: use from and to wallet terminology everywhere * chore: add db migration * fix: display correct refund transaction when refunding in cli * fix: show correct timeout in cli * feat: recover pending chain swaps * fix: correctly set external pay when creating submarine swap * feat: display currency of lockup tx in cli * fix: dont try to broadcast empty transaction --------- Co-authored-by: Kilian <19181985+kilrau@users.noreply.github.com>
can be added back later when batching has been refactored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.