refactor: simplify internal onchain interfaces #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackstar12
force-pushed
the
onchain-refactor
branch
3 times, most recently
from
30c74e8
to
281d15e
Compare
michael1011
reviewed
May 4, 2024
cmd/boltzd/boltzd.go
Outdated
| chain.Liquid.Tx = client | ||
| } | ||
|
|
||
| // use boltz in regtest to avoid situations where electrum doesnt know about the tx yet |
There was a problem hiding this comment.
Suggested change
| // use boltz in regtest to avoid situations where electrum doesnt know about the tx yet | |
| // Use the Boltz API in regtest to avoid situations where electrum doesnt know about the tx yet |
jackstar12
force-pushed
the
onchain-refactor
branch
4 times, most recently
from
35bc053
to
bf41e62
Compare
michael1011
approved these changes
May 5, 2024
jackstar12
force-pushed
the
onchain-refactor
branch
2 times, most recently
from
26d02c8
to
4830e73
Compare
jackstar12
force-pushed
the
onchain-refactor
branch
from
4830e73
to
b55dc91
Compare
Co-authored-by: michael1011 <me@michael1011.at>
blocks until payment is finished otherwise
jackstar12
force-pushed
the
onchain-refactor
branch
from
1b0a290
to
92b550c
Compare
…e electrum is cleaned up
jackstar12
force-pushed
the
onchain-refactor
branch
from
92b550c
to
f5fedfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage of wallets / ln nodes as providers for fee estimations / block updates always involved additional complexity which doesnt really pay off since we use default mempool endpoints in testnet / mainnet anyways, while power users can still configure their own mempool / electrum server.
closes: #122