Fix claimTransactionId typo #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael1011
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So today I couldn't finish a reverse swap with Boltz due to a weird error:
Could not decode claim address of Reverse Swap: decoded address is of unknown format. Debugging with the almightylog.Printfrevealed that the claim address is actually empty! But it was present in the database as I found usingsqlite3. After about an hour of searching for clues I accidentally noticed that a particular field is used twice for different SQL columns. I have no idea how it worked before and why it stopped today (I used the same binary a couple of days ago), maybe the column order returned by SQLite was different so theclaimAddresswas put afterclaimTransactionId(which is of course empty before we sweep the funds!).Anyway, now it's fixed. Hopefully, Boltz will see less failed swaps now, every such swap costs them on-chain fees and on Lightning cancellation is 100% free.