Create Swap Instruction #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhlx
commented
Dec 20, 2021
|
|
||
| check_accounts(program_id, &market_state, &accounts).unwrap(); | ||
| let callback_info = CallBackInfo { | ||
| user_account: Pubkey::default(), |
There was a problem hiding this comment.
maybe can change callbackinfo to use Option instead, but that felt messy (had to update a bunch of places, change CALLBACK_INFO_LEN, etc.)
There was a problem hiding this comment.
I think it's good you didn't do it, there really is no benefit in using an Option here :
- Requires an extra byte to encode (which means every node in the critbit tree is just that little bit larger => more expensive to deploy new markets)
- The only benefit of using an option is that option::is_some is inherently faster than
Pubkey::eq, but we actually never perform the expensive comparison between that key andPubkey::default
|
For now this LGTM, I'll wait for the TS side to be done as well before final review and merge. |
ellttBen
force-pushed
the
main
branch
2 times, most recently
from
fbdded6
to
661ba30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo: