This repository has been archived by the owner on Feb 29, 2024. It is now read-only.
Update vagrant nodepool provider #378
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandelman-a
previously requested changes
Apr 27, 2017
inventory/group_vars/vagrant
Outdated
| @@ -27,12 +27,15 @@ nodepool_labels: | |||
| nodepool_providers: | |||
| - name: cicloud | |||
| cloud: cicloud | |||
| max-servers: 10 | |||
| max-servers: 3 | |||
There was a problem hiding this comment.
for developers, we should probably keep this to 1 by default just to ease resource usage on the cloud
inventory/group_vars/vagrant
Outdated
| @@ -27,12 +27,15 @@ nodepool_labels: | |||
| nodepool_providers: | |||
| - name: cicloud | |||
| cloud: cicloud | |||
| max-servers: 10 | |||
| max-servers: 3 | |||
| images: | |||
| - name: ubuntu-xenial | |||
| min-ram: 2048 | |||
There was a problem hiding this comment.
we can bump this down to 512 as well to conserve resources
inventory/group_vars/vagrant
Outdated
| images: | ||
| - name: ubuntu-xenial | ||
| min-ram: 2048 | ||
| diskimage: ubuntu-xenial | ||
| private-key: /var/lib/nodepool/.ssh/id_rsa | ||
| networks: | ||
| - name: 'nodepool' | ||
| public: False |
There was a problem hiding this comment.
I dont think we want to encourage devs to boot slaves on our production nodepool environment. We could instead default to the 'internal' network and the slaves should be reachable via fixed ip from the dev env, assuming it to was booted on the internal network.
There was a problem hiding this comment.
Also, tip: we also need user-home and username set on the image so that nodepool, otherwise it defaults to jenkins
Update the nodepool provider defined in the vagrant group vars to work with the current opentechsjc network setup. There are multiple networks, so we must specify one to use. Also reduce the minimum nodes to reduce resource overhead. Signed-off-by: K Jonathan Harker <Jonathan.Harker@ibm.com>
jesusaurus
force-pushed
the
vagrant-nodepool
branch
from
977d1cd
to
36c8d6d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the nodepool provider defined in the vagrant group vars to
work with the current opentechsjc network setup. There are multiple
networks, so we must specify one to use. Also reduce the minimum nodes
to reduce resource overhead.
Signed-off-by: K Jonathan Harker Jonathan.Harker@ibm.com