Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR and deploy process doc to repo #46

Merged
merged 5 commits into from Mar 23, 2017
Merged

Add PR and deploy process doc to repo #46

merged 5 commits into from Mar 23, 2017

Conversation

codemonkey9000
Copy link

@keenbrowne and @dariusgarza please let me know if you think this sufficiently covers our bases for QA and deploy process!

Any additions are welcome.

@dariusgarza
Copy link

Looks great so far. Maybe add a warning or intro in the deployment section about NEVER touching master, and to treat dev as a psuedo-master.

Would it also be helpful to include "review PR checklist" before deployment?

Think we can add a few bullet points to clarify how to review functionality. Search could say something like: 1. Attempt a search via pressing enter on mobile and desktop, 2. Search via pressing search button on mobile/desktop, etc...

Will update if I think of anything else, Thanks!

@dariusgarza
Copy link

Should we also add something like "merge origin/dev into local branch" before asking for a PR and then once again during the PR review?

@dariusgarza
Copy link

dariusgarza commented Mar 23, 2017

Let's add this:

npm install broken-link-checker -g
blc —help gives you all of the options but the standard check is blc http://yoursite.com -ro

also, i think line 6 should be blc instead of brc?

@codemonkey9000 codemonkey9000 merged commit 228bc71 into dev Mar 23, 2017
@codemonkey9000 codemonkey9000 deleted the process-doc branch March 23, 2017 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants