Skip to content

Commit

Permalink
Updated custom request overrides to better match original intent
Browse files Browse the repository at this point in the history
This updates the custom Request handler to provide only the scheme and
host on the `getSchemeAndHttpHost` call, instead of providing the whole
APP_URL value, while adding an override to the 'getBaseUrl' to use the
APP_URL content instead of the guessed/detected Symfony value.

Untested apart from simple local setup.

Related to #2765
  • Loading branch information
ssddanbrown committed Apr 2, 2022
1 parent affae2e commit 4dce03c
Showing 1 changed file with 23 additions and 8 deletions.
31 changes: 23 additions & 8 deletions app/Http/Request.php
Expand Up @@ -8,20 +8,35 @@ class Request extends LaravelRequest
{
/**
* Override the default request methods to get the scheme and host
* to set the custom APP_URL, if set.
* to directly use the custom APP_URL, if set.
*
* @return \Illuminate\Config\Repository|mixed|string
* @return string
*/
public function getSchemeAndHttpHost()
{
$base = config('app.url', null);
$appUrl = config('app.url', null);

if ($base) {
$base = trim($base, '/');
} else {
$base = $this->getScheme() . '://' . $this->getHttpHost();
if ($appUrl) {
return implode('/', array_slice(explode('/', $appUrl), 0, 3));
}

return $base;
return parent::getSchemeAndHttpHost();
}

/**
* Override the default request methods to get the base URL
* to directly use the custom APP_URL, if set.
*
* @return string
*/
public function getBaseUrl()
{
$appUrl = config('app.url', null);

if ($appUrl) {
return rtrim(implode('/', array_slice(explode('/', $appUrl), 3)), '/');
}

return parent::getBaseUrl();
}
}

0 comments on commit 4dce03c

Please sign in to comment.