Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add attachment file upload upon drag/drop or paste within the editors #3230

Open
christianhz01 opened this issue Feb 2, 2022 · 7 comments

Comments

@christianhz01
Copy link

Describe the feature you'd like

That a PDF can be pasted like an image or opened with a preview, without download.
-> exactly as it was solved for example in Nextcloud

Describe the benefits this feature would bring to BookStack users

No unnecessary downloads of PDFs that you just want to have a quick look at.

Additional context

No response

@ssddanbrown
Copy link
Member

Hi @christianhz01,

That a PDF can be pasted like an image or opened with a preview, without download.

It sounds like there are two requests here, although I'm not 100% sure about what is desired. I'm guessing:

  1. Allow pasting/drag+dropping of files into the page editor, to be uploaded as an attachment.
  2. Allow PDF attachment files to be viewed in-browser without download first.

The second of the above can be achieved, when viewing a page, by clicking the attachment in the sidebar while holding down shift, Or by appending ?open=true to the attachment link. At some point I would like tot make this more obvious in the interface but I've found that coming up with the right user interface has been tricky. I think this may already be covered by #705.

In reference to (1) in the above, is my assumption correct in regards to the description of the feature? If so I could re-purpose this issue to focus on that.

@christianhz01
Copy link
Author

Hi @ssddanbrown
Thanks for the answer. Both would be very useful features :)

@ssddanbrown
Copy link
Member

Okay, will therefore re-focus this issue to attachment paste/drag+dropping.

@ssddanbrown ssddanbrown changed the title [Feature Request]: PDF preview [Feature Request]: Allow attachment files to be uploaded upon drag/drop or paste within the editors Feb 3, 2022
@ssddanbrown ssddanbrown changed the title [Feature Request]: Allow attachment files to be uploaded upon drag/drop or paste within the editors [Feature Request]: Add attachment file upload upon drag/drop or paste within the editors Feb 3, 2022
@ghost
Copy link

ghost commented Apr 6, 2023

Hey,

are there any updates on that topic?
I would like to import PDF´s from my local mashine therefore drag and drop would be perfect for me.
The Request #705 was nice, but i seem to fail uploading my local files.

thanks for your great work! :-)

@kevinmckeown
Copy link

+1 for import pdf

@zznobzz
Copy link

zznobzz commented Oct 1, 2023

Very need import pdf!

@AleixoLucas42
Copy link

Is there possible now to upload pdfs ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants