Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Month missing when exporting instructions #3650

Closed
Statium opened this issue Aug 15, 2022 · 7 comments
Closed

Month missing when exporting instructions #3650

Statium opened this issue Aug 15, 2022 · 7 comments
Labels
🐛 Bug
Milestone
v22.09.1

Comments

@Statium
Copy link
Contributor

Statium commented Aug 15, 2022

Describe the Bug

When exporting a statement, the month was not specified in the creation date
image

Steps to Reproduce

  1. Export PDF

Expected Behaviour

Screenshots or Additional Context

No response

Browser Details

No response

Exact BookStack Version

v22.07.02

PHP Version

8.3

Hosting Environment

WinServer
@Statium
Copy link
Contributor Author

Statium commented Aug 15, 2022

The problem is in the encoding (at least when choosing the Russian language by default). When exporting html, the month is replaced by question marks.

@ssddanbrown
Copy link
Member

Very much related to #3590, Possibly due to missing locale data. I'm not sure how locales work in Windows environments.

@Statium Can you provide any additional detail regarding your environment, and actual PHP version? Since PHP8.3 is not a thing that exists right now.

@Statium
Copy link
Contributor Author

Statium commented Aug 15, 2022

PHP 8.1.5
Windows Server 2019

ssddanbrown added a commit that referenced this issue Sep 2, 2022
@ssddanbrown
Updated & improved language locale handling
9158a66 
Extracted much of the language and locale work to a seperate, focused class.
Updated php set_locale usage to prioritise UTF8 usage.
Added locale options for windows.
Clarified what's a locale and a bookstack language string.

For #3590 and maybe #3650
@Statium
Copy link
Contributor Author

Statium commented Sep 9, 2022

@ssddanbrown In Russian, the problem is not solved.
I am attaching a screenshot.
image

@Statium
Copy link
Contributor Author

Statium commented Sep 18, 2022 •
edited

image
I corrected line 52 in the LanguageManager.php file and it solved the problem (added UTF-8)
image

ssddanbrown added a commit that referenced this issue Sep 20, 2022
@ssddanbrown
Added extra setlocale format to help windows support
050d69e 
Related to #3650
@ssddanbrown
Copy link
Member

Thanks for confirming what works @Statium.
I've made changes in 050d69e to include the specific format you displayed in your last message. These will be part of v22.09.1.

@7357-2022 7357-2022 mentioned this issue Sep 20, 2022
Merged
@Statium
Copy link
Contributor Author

Statium commented Oct 31, 2022

@ssddanbrown The problem recurred in 22.10.1

@Statium Statium mentioned this issue Nov 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug
Milestone
v22.09.1
Development

No branches or pull requests
2 participants
@Statium @ssddanbrown