I can't type after exiting the "Edit Code" window #4109
Labels
Milestone
Comments
|
Can confirm this, thanks for reporting. |
|
@ssddanbrown Does this issue still exist ?
|
|
@esakkiraja100116 Yes, I could reproduce this on our demo site from a quick test. |
|
okay thanks @ssddanbrown. |
ssddanbrown
added a commit
that referenced
this issue
May 7, 2023
Focus now returns to the editor properly when you quit out the code editor without saving. This also sets the return location to be correct on normal saving (Would sometimes jump to the end of the document). For #4109.
|
Proper focus handling for cancel/close code editor window has now been added in 3bcbf6b and will be part of the next patch release. |
|
Cool. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the Bug
I can't resume editing the document by typing after exiting the "Edit Code" window by pressing the Escape key or clicking on the X in the top right. This issue is not present when I click "Save Code" instead.
After closing the "Edit Code" window with the escape key or X then I have to click into the document in order to get a cursor and continue editing the document.
Steps to Reproduce
<ctrl+e>
then try to edit the document. you can't.
Expected Behaviour
I should be able to edit the document same as if I had clicked "Save Code"
Screenshots or Additional Context
No response
Browser Details
chrome 111.0.5563.65 windows 10
Exact BookStack Version
BookStack v23.02.1
PHP Version
8.2 from php:8.2-apache-buster from solidnerd/bookstack:23.2.1
Hosting Environment
solidnerd/bookstack:23.2.1 docker
The text was updated successfully, but these errors were encountered: