Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor scrolling doesn‘t work on mobile devices #4466

Closed
BnAmN opened this issue Aug 28, 2023 · 2 comments
Closed

Editor scrolling doesn‘t work on mobile devices #4466

BnAmN opened this issue Aug 28, 2023 · 2 comments

Comments

@BnAmN
Copy link

BnAmN commented Aug 28, 2023

Describe the Bug

On mobile devices (and mobile-sized desktop browsers) it‘s not possible to scroll the Markdown editor vertically (using touch or mouse wheel) if there are more lines than the viewport can display.

I‘m encountering this issue for a while now, but sadly I can‘t really tell the version I first encountered it. But it was definitely working fine in earlier versions.

I was able to workaround the issue by adding the following CSS:

.markdown-editor-wrap {
  height: 100%;
}

Steps to Reproduce

  1. Use a mobile device (or a mobile-sized desktop browser)
  2. Open a Book
  3. Enter „Edit“ mode
  4. In case there aren‘t enough lines: add some new lines until you leave the bottom of the screen
  5. Try to scroll down to the bottom line

Expected Behaviour

The editor is vertically scrollable.

Screenshots or Additional Context

No response

Browser Details

Any browser

Exact BookStack Version

v23.06.2

PHP Version

8.1

Hosting Environment

Docker

@ssddanbrown
Copy link
Member

Thanks @BnAmN, can confirm this issue. Getting a bit close, so could slip, but I've assigned to try to sneak into next upcoming feature release.

Dev notes

Needs flex balancing and maybe min-heights applied to get the flex to fit container.
Sections can have flex basis' left over from horizontal split control, which can interfere. Needs to work-with/override that.

@ssddanbrown ssddanbrown self-assigned this Aug 30, 2023
ssddanbrown added a commit that referenced this issue Aug 30, 2023
Added min-height to flex elements to ensure they properly flex within
the container rathen than adjust to content.

For #4466
@ssddanbrown
Copy link
Member

Addressed in dc77233, to be part of v23.08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants