Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to edit pages after upgrade to 23.08.1 #4510

Closed
2 tasks done
topazb opened this issue Sep 4, 2023 · 7 comments
Closed
2 tasks done

Unable to edit pages after upgrade to 23.08.1 #4510

topazb opened this issue Sep 4, 2023 · 7 comments

Comments

@topazb
Copy link

topazb commented Sep 4, 2023

Attempted Debugging

  • I have read the debugging page

Searched GitHub Issues

  • I have searched GitHub for the issue.

Describe the Scenario

After upgrading to v23.08.1
I'm unable to edit already existing pages
The edit page appears blank

Screenshot 2023-09-04 at 11 45 05

Exact BookStack Version

23.08.1

Log Content

No response

PHP Version

No response

Hosting Environment

upgraded using the official script

@daviserez
Copy link

daviserez commented Sep 4, 2023

I'v got a similar issue, but only on some pages and I can't figure out why some pages work and others don't.

Cleared browser cache and app caches.

CleanShot 2023-09-04 at 11 23 47@2x

@cdrfun
Copy link

cdrfun commented Sep 4, 2023

I can +1 to @daviserez issue. Tested it on different machines with up-to-date Firefox, Edge and Chrome. If a page is broken, it is broken on all browser/machines.

@ssddanbrown ssddanbrown added this to the v23.08.2 milestone Sep 4, 2023
@ssddanbrown ssddanbrown self-assigned this Sep 4, 2023
ssddanbrown added a commit that referenced this issue Sep 4, 2023
Could error upon div elements without classes, including drawings.

Related to #4510 and #4509
@rockenren
Copy link

Not all pages are affected, but 2c20abc alone doesn't resolve the issue.

@ssddanbrown
Copy link
Member

but 2c20abc alone doesn't resolve the issue.

@rockenren Can you confirm how you tested that? Was just about to push it into release but will hold off if it doesn't address the issue.

@rockenren
Copy link

but 2c20abc alone doesn't resolve the issue.

@rockenren Can you confirm how you tested that? Was just about to push it into release but will hold off if it doesn't address the issue.

since this is a small fix: just copied raw from newer revision to current one.
Cleared bookstack caches and restarted web server/php, CTRL+F5 in browser.

Then tried editing broken page again, still showing no content and have same js exception in dev console.

Maybe I did something wrong? Should I pull from development branch via git for this single commit?

@ssddanbrown
Copy link
Member

@rockenren JavaScript (and CSS) has to be built/bundled into the expected output file(s). I'm assuming this was not done based upon your response so I went ahead and pushed the release.

Thanks @topazb and everyone else for reporting/confirming the issue.
Should now be addressed in v23.08.2, but please let me know if you continue to have issues and I'll re-open.

@rockenren
Copy link

@rockenren JavaScript (and CSS) has to be built/bundled into the expected output file(s). I'm assuming this was not done based upon your response so I went ahead and pushed the release.

Thanks @topazb and everyone else for reporting/confirming the issue. Should now be addressed in v23.08.2, but please let me know if you continue to have issues and I'll re-open.

yes, i've suspected this, my bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants