Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS TypeError in Firefox #4531

Closed
aldem opened this issue Sep 11, 2023 · 1 comment
Closed

JS TypeError in Firefox #4531

aldem opened this issue Sep 11, 2023 · 1 comment
Labels
🐛 Bug 💻 Front-End
Milestone
v23.08.3

Comments

@aldem
Copy link

aldem commented Sep 11, 2023 •
edited
Loading

Describe the Bug

When opening the page (any page) Firefox shows an error in console.

image

Steps to Reproduce

Visit any page on demo instance, for example: https://demo.bookstackapp.com/books/bookstack-demo-site/page/logging-in-to-the-demo-site

This happens on every page and of course not only on demo instance.

Expected Behaviour

While the error seems to be harmless it might be a good idea to find the root cause and fix it.

Screenshots or Additional Context

No response

Browser Details

Firefox 117.0, Windows 11

Exact BookStack Version

v23.08.2
@aldem aldem added the 🐛 Bug label Sep 11, 2023
ssddanbrown added a commit that referenced this issue Sep 11, 2023
@ssddanbrown
Comments: Fixed JS error when lacking commenting permissions
99eb3e5 
The page comments component would throw an error due to references to
form elements/content, when form elements may not exist due to
permisisons.

For #4531
@ssddanbrown ssddanbrown added this to the v23.08.3 milestone Sep 11, 2023
@ssddanbrown
Copy link
Member

Thanks for reporting @aldem.
I've addressed this in 99eb3e5. Will be part of the next release (feature release or a patch release if we need to deploy one beforehand).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug 💻 Front-End
Milestone
v23.08.3
Development

No branches or pull requests
2 participants
@aldem @ssddanbrown