Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address undesirable URLs being considered for back redirection #4656

Closed
ssddanbrown opened this issue Nov 7, 2023 · 0 comments
Closed

Address undesirable URLs being considered for back redirection #4656

ssddanbrown opened this issue Nov 7, 2023 · 0 comments

Comments

@ssddanbrown
Copy link
Member

ssddanbrown commented Nov 7, 2023

This is a specific problem in scenarios where the Referrer header is not present (browser settings or via Referrer-Policy header).
The app falls back to previous URL tracked in the session, but this may not reflect an actual user page.
An example of this is secure images. Also relevant is #4649.
This leads to users being redirected to odd endpoints in such scenarios.

We could potentially override session or redirect handling to not track undesireable URLs.
Alternatively, we could avoid using the in-built back redirection within BookStack for an alternative option. As an example, we could provide the redirect path within the request (some care to be taken here to prevent open redirection).

Potentially revert the changes in ea0469e once done to allow PWA manifest personalisation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant