Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LDAP_USER_FILTER env option to use new placeholder format #4967

Closed
ssddanbrown opened this issue Apr 22, 2024 · 1 comment
Closed

Update LDAP_USER_FILTER env option to use new placeholder format #4967

ssddanbrown opened this issue Apr 22, 2024 · 1 comment
Labels
📖 Docs Update 🏭 Back-End 🔧 Maintenance
Milestone
v24.05

Comments

@ssddanbrown
Copy link
Member

Update LDAP_USER_FILTER env option to use {user} in addition to ${user}.
The existing ${user} technically can be considered as a nested variable by dotenv. Most cases it's fine unless a user variable is defined but best to move away from this.
Doing something similar for #4732, so best to align these now.
Keep support for old format for forwards compatibility though.
Don't think it will conflict with existing cases, but maybe should still alert about this?

Doc Updates

  • Update existing ldap docs with new format.
  • Update advisory to suggest change and potential compatibility?
@ssddanbrown ssddanbrown added this to the Next Feature Release milestone Apr 22, 2024
ssddanbrown added a commit that referenced this issue Apr 28, 2024
@ssddanbrown
LDAP: Updated default user filter placeholder format
6b68196 
To not conflict with env variables, and to align with placeholders used
for PDF gen command.
Added test to cover, including old format supported for
back-compatibility.
For #4967
@ssddanbrown
Copy link
Member Author

Closed via 6b68196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📖 Docs Update 🏭 Back-End 🔧 Maintenance
Milestone
v24.05
Development

No branches or pull requests
1 participant
@ssddanbrown