Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling Comments #541

Closed
Ethanb00 opened this issue Oct 3, 2017 · 14 comments
Closed

Disabling Comments #541

Ethanb00 opened this issue Oct 3, 2017 · 14 comments

Comments

@Ethanb00
Copy link

Ethanb00 commented Oct 3, 2017

Desired Feature: Ability to disable/hide comments either globally and/or by page/chapter/book.

For my purposes (Technical Documentation for a small team), the comments section, for the most part, is an unneeded resource. I totally under the utility for others, but I do not intend on using it.

As a result, it would be nice to be able to disable it. I don't have a preference if that switch is global, by book, by chapter, or by page. Turning it off would remove an unused a page component and clean up the UI a bit.

Thank you!

@Shackelford-Arden
Copy link

I like this idea. Definitely like the idea of having book/chapter level control of comments.

I realize you want to keep this simple @ssddanbrown but would this be something that we could potentially look at adding to a Chapter/Book Settings menu?

@slimninja
Copy link

+1

@criskolkman
Copy link

+1 for me!

@faizmali
Copy link

We would greatly appreciate this feautre as well

@galaxyfeeder
Copy link

+1

@Abijeet
Copy link
Member

Abijeet commented Oct 28, 2017

Ok, there a few ways this can be done,

Option Role
Global option Only administrator can do this.
Option on the book People who have modify access to the book
Option on the chapter People who have modify access to the chapter
Option on the page People who have modify access to the page

I think row 1 and 2 should suffice. Let me know what you guys think. Once we have the requirements nailed down and @ssddanbrown has taken a look, I can submit a PR.

@Ethanb00
Copy link
Author

@Abijeet: I concur. Chapter and page are likely too granular. Per-book or global rights fit much better in terms of generating forms for documentation.

Thank you for your work!

@ssddanbrown
Copy link
Member

ssddanbrown commented Nov 11, 2017

Yeah, I think we should keep this at a global (admin) level. Will mark up for next feature release (v0.19). @Abijeet Feel free to go ahead with this one if you'd like.

@Abijeet
Copy link
Member

Abijeet commented Nov 15, 2017

Have started working on this, few things to note -

  1. Added an option under app settings - Disable comments
  2. If this is turned on then,
    1. Adding comments is disabled.
    2. Existing comments will not be shown.
    3. The entire comments section is removed and no message is shown stating that comments are disabled.

Two things are debatable here,

  1. Do we show a message stating that comments are disabled? Not sure if it's needed, but can be easily added.
  2. Do we show existing comments? I removed them to save an extra query to fetch the comments.

@Abijeet Abijeet mentioned this issue Nov 15, 2017
1 task
@Shackelford-Arden
Copy link

For what it's worth, my opinion would be that if you disable comments, don't show them. I like what you said about saving ourselves the extra query.

@Ethanb00
Copy link
Author

I think the absence of comments is clear enough that they are disabled. My goal with disabling them is to have as little extra stuff as possible on the page.

@jleroy
Copy link

jleroy commented Nov 16, 2017

IMHO @Abijeet choices are good ones. :)

@ssddanbrown
Copy link
Member

I totally agree, Just hide all existence of comments with the option enabled.

@ssddanbrown
Copy link
Member

Featured now added by @Abijeet within #593. Will be in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

9 participants