-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabling Comments #541
Comments
I like this idea. Definitely like the idea of having book/chapter level control of comments. I realize you want to keep this simple @ssddanbrown but would this be something that we could potentially look at adding to a Chapter/Book Settings menu? |
+1 |
+1 for me! |
We would greatly appreciate this feautre as well |
+1 |
Ok, there a few ways this can be done,
I think row 1 and 2 should suffice. Let me know what you guys think. Once we have the requirements nailed down and @ssddanbrown has taken a look, I can submit a PR. |
@Abijeet: I concur. Chapter and page are likely too granular. Per-book or global rights fit much better in terms of generating forms for documentation. Thank you for your work! |
Yeah, I think we should keep this at a global (admin) level. Will mark up for next feature release (v0.19). @Abijeet Feel free to go ahead with this one if you'd like. |
Have started working on this, few things to note -
Two things are debatable here,
|
For what it's worth, my opinion would be that if you disable comments, don't show them. I like what you said about saving ourselves the extra query. |
I think the absence of comments is clear enough that they are disabled. My goal with disabling them is to have as little extra stuff as possible on the page. |
IMHO @Abijeet choices are good ones. :) |
I totally agree, Just hide all existence of comments with the option enabled. |
Desired Feature: Ability to disable/hide comments either globally and/or by page/chapter/book.
For my purposes (Technical Documentation for a small team), the comments section, for the most part, is an unneeded resource. I totally under the utility for others, but I do not intend on using it.
As a result, it would be nice to be able to disable it. I don't have a preference if that switch is global, by book, by chapter, or by page. Turning it off would remove an unused a page component and clean up the UI a bit.
Thank you!
The text was updated successfully, but these errors were encountered: