Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes image deletion failing in subdirectory. #1143

Merged
merged 1 commit into from Nov 27, 2018
Merged

Conversation

Abijeet
Copy link
Member

@Abijeet Abijeet commented Nov 24, 2018

Fixes #1092

I was unable to test it on a sub-directory, since while setting up was getting an issue stating -

[Sun Nov 25 00:14:25.175814 2018] [core:error] [pid 30398] [client ::1:50186] AH00124: Request exceeded the limit of 10 internal redirects due to probable configuration error. Use 'LimitInternalRecursion' to increase the limit if necessary. Use 'LogLevel debug' to get a backtrace.

But I'm fairly certain that this will fix the issue. Tested on the PHP localhost server.

Signed-off-by: Abijeet abijeetpatro@gmail.com

Fixes #1092

Signed-off-by: Abijeet <abijeetpatro@gmail.com>
@Abijeet Abijeet self-assigned this Nov 24, 2018
@ssddanbrown ssddanbrown added this to the BookStack Beta v0.24.3 milestone Nov 27, 2018
@ssddanbrown ssddanbrown merged commit eac82c4 into master Nov 27, 2018
@ssddanbrown ssddanbrown deleted the fix-image-delete branch November 27, 2018 21:22
@ssddanbrown
Copy link
Member

@Abijeet Good find, Have merged in now, Thought I'd put together a little patch release tonight. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

delete image faild
2 participants