Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing composer install inside docker app container #1698

Merged
merged 1 commit into from Oct 5, 2019
Merged

Fixing composer install inside docker app container #1698

merged 1 commit into from Oct 5, 2019

Conversation

ammardev
Copy link
Contributor

@ammardev ammardev commented Oct 3, 2019

Describe the bug
Can not run composer install inside app docker container. The error appears because Composer can not find git.

Steps To Reproduce
Steps to reproduce the behavior:
The same steps explained in the README file.

  1. Clone master branch.
  2. Run the command: docker-compose run app composer install.
  3. The error appears as the image in screenshots.

Expected behavior
Installing Packages inside Docker container.

Screenshots
Tested on my local machine and on a Digitalocean droplet.
image

My Configuration:

  • Exact BookStack Version: The version of master branch.
  • PHP Version: 7.3
  • Hosting Method (Nginx/Apache/Docker): Docker.

This pull request adding git to the docker image. So Composer can install packages without the git error.

@ssddanbrown ssddanbrown added this to the v0.28.0 milestone Oct 5, 2019
@ssddanbrown
Copy link
Member

Thanks for reporting and fixing @3mmarg97.

@ssddanbrown ssddanbrown merged commit 6736779 into BookStackApp:master Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants