Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Russian slug and Multibyte String #582

Merged
merged 1 commit into from Nov 11, 2017
Merged

Conversation

vldmr-k
Copy link
Contributor

@vldmr-k vldmr-k commented Nov 3, 2017

Generate russian slug not correct if using strtolower.
Better using mb_strtolower if that function exists.

@ssddanbrown ssddanbrown added this to the BookStack Beta v0.18.5 milestone Nov 11, 2017
@ssddanbrown ssddanbrown merged commit 6b2581d into BookStackApp:master Nov 11, 2017
@ssddanbrown
Copy link
Member

@wowkaster Thanks for creating this pull request. I made a small change just to remove the check for mb_strtolower since mbstring is a required PHP extension for BookStack. Otherwise all good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants