-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Space after number in section title #25
Comments
Ah, okay. This kind of stuff will only work if you add the I found a bug in my styles that caused my |
What is wrong with a selector like .theorem-like > h1 .type:after That seems to avoid the need to put a class on the h5. |
I opted for
|
Yes, we need to support both h1 and h5 (and nothing else) for the title of a Theorem. But right now (actually, when I looked a couple hours ago), putting class="heading" made I don't understand the argument against allowing a classless h1 or h5 for the title of a theorem. |
The goal is to decouple the CSS from the HTML. The CSS should not have to know what HTML element is being used. Instead, the CSS should provide a contract to you and Rob. If you use these classes, you will get these styles. Theory aside, I think the fact that we couldn't agree on the correct By providing a separate contract that requires |
Okay, I'll add the class="title" and Rob will have to add a hide-title On Wed, 6 Aug 2014, Michael DuBois wrote:
|
Actually, looks like this is still an issue. Sorry guys. It was working before... :-/ |
Here's an example where it's broken: One catch is that sometimes the class |
This is in develop now. If you're still having trouble with it, double check that codenumbers are given the |
Seems to work for me, but the "type" still seems to be hidden by default. On Wed, 13 Aug 2014, Michael DuBois wrote:
|
There should be a space added after the .codenumber span in (sub)section titles and theorem/definiiton-like environments. These were in the add-on.css at one point.
MBX seems to insert the space in some cases, but SL2X leaves no space between the spans,
so CSS has to add it.
Note that if you put class="heading" in the h tag of a title, then the .type span is hidden.
(I.e. it says "2.2 The Division Algorithm" not "Section 2.2 The Division Algorithm).
But I want the word "Section" to appear, so I don;t add a class to the h tag.
The text was updated successfully, but these errors were encountered: