Added karatsuba multiplication #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laouen
requested changes
Jul 22, 2019
There was a problem hiding this comment.
The code looks fine, but you should have duplicated tests instead of setting k_multiplication as the default multiplication. Do de following changes and commit so we merge this PR:
- Revert the default multiplication to long multiplication.
- Duplicate tests to have the same tests for each multiplication algorithm.
|
Merged, there is issues, but we going back to a single branch for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To demonstrate that the tests work, I've kept the default multiplication as Karatsuba.
Once I get the thumbs up, I'll revert the default multiplication to long multiplication and then karatsuba can only be accessed via function k_multiply.