Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Unit Tests for FITS module along with some minor bug fixes #151

Closed
wants to merge 1 commit into from

Conversation

gopi487krishna
Copy link
Collaborator

Description

This pull request adds tests for testing the core functionality of FITS module along with some bug fixes
Following Changes are Made :

  • Added Tests for Card
  • Refactored Code in Primary HDU
  • Added Tests for Binary Table, ASCII table, HDU, Primary HDU ( with
    bug-fixes)
  • Updated Copyright Information and reformatted the code (clang-format)
  • Refactored Code in Card struct

Note : The tests added do not perform exhaustive testing but rather test test the core functionality and working of FITS Module ( They can be called more like standoff's) . This has been done to introduce TDD style of Development in FITS Module

References

None as such

Task list

  • Add test case(s)
  • Ensure all CI builds pass
  • Review and approve

@gopi487krishna
Copy link
Collaborator Author

@lpranam Sir i have rolled back the formatting changes. Now the differences should be clear :)

@gopi487krishna
Copy link
Collaborator Author

@lpranam Kindly review sir

Copy link
Member

@lpranam lpranam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over the course of GSoC these changes were gradually introduced in other PRs so no need for this now.

@lpranam lpranam closed this Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants