Fix return immediately

BoostIO · Jan 11, 2020 · d628990 · d628990
1 parent d7f8eb8
commit d628990
Showing 1 changed file with 12 additions and 12 deletions.
diff --git a/src/components/NotePage/NoteDetail/NoteDetail.tsx b/src/components/NotePage/NoteDetail/NoteDetail.tsx
@@ -1,4 +1,5 @@
 import React from 'react'
+import { includes } from 'ramda'
 import {
   NoteDoc,
   NoteDocEditibleProps,
@@ -299,18 +300,17 @@ export default class NoteDetail extends React.Component<
   }
 
   appendNewTag = () => {
-    const includes = this.state.tags.includes(this.state.newTagName)
-    if (isTagNameValid(this.state.newTagName) && !includes) {
-      this.setState(
-        prevState => ({
-          newTagName: '',
-          tags: [...prevState.tags, prevState.newTagName]
-        }),
-        () => {
-          this.queueToSave()
-        }
-      )
-    }
+    if (includes(this.state.newTagName, this.state.tags)) { return }
+    if (!isTagNameValid(this.state.newTagName)) { return }
+    this.setState(
+      prevState => ({
+        newTagName: '',
+        tags: [...prevState.tags, prevState.newTagName]
+      }),
+      () => {
+        this.queueToSave()
+      }
+    )
   }
 
   removeTagByName = (tagName: string) => {