Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't copy code block if no type specified #749

Closed
myicq opened this issue Dec 29, 2020 · 3 comments
Closed

Can't copy code block if no type specified #749

myicq opened this issue Dec 29, 2020 · 3 comments
Labels
bug 🐛 Issue concerns a bug.
Projects

Comments

@myicq
Copy link

myicq commented Dec 29, 2020

Current behavior

If you do not specify a type for a code fence, the text won't get copied to clipboard, even if icon to copy is there.

Text is displayed as code block.

Expected behavior

Copy icon to work when it's there.

Steps to reproduce

Make a code block without type:

         ```
         This is some text 
         ```

Go to preview. Copy icon is there, but no "save" icon. Copy icon does not work.

Go back to edit, and put type:

         ```text
         This is some text 
         ```

Now the copy icon and save icon are both there, and text can be copied.

Environment

Win10, 64 bit, Boostnote 0.12.3

Desktop/Web

Boost Note 0.12.3, Win10 64 bit.

@myicq
Copy link
Author

myicq commented Dec 29, 2020

NOTE: found that this is a duplicate of issue #585, but confirmed for latest version and on Windows platform.

@Komediruzecki
Copy link
Contributor

Komediruzecki commented Dec 29, 2020

Hi myicq,

I think this was forgotten so I created a bugfix, you can track it here: #750

@Komediruzecki Komediruzecki added the bug 🐛 Issue concerns a bug. label Dec 29, 2020
@Komediruzecki
Copy link
Contributor

Since #750 is merged, I'll close this issue. The fix will be available in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Issue concerns a bug.
Projects
No open projects
Dev kanban
  
Done
Development

No branches or pull requests

2 participants